Skip to content

giscus.ejs needs to check for darkMode#12702

Merged
gordonwoodhull merged 1 commit intomainfrom
bugfix/giscus-without-dark-mode-1.8
May 7, 2025
Merged

giscus.ejs needs to check for darkMode#12702
gordonwoodhull merged 1 commit intomainfrom
bugfix/giscus-without-dark-mode-1.8

Conversation

@gordonwoodhull
Copy link
Copy Markdown
Member

And not use authorPrefersDark that won't be declared if dark mode not enabled.

fixes #12700

This is the v1.8 version.

and not use variables that won't be declared
@gordonwoodhull gordonwoodhull added this to the v1.8 milestone May 7, 2025
@gordonwoodhull gordonwoodhull merged commit f08f424 into main May 7, 2025
49 checks passed
@gordonwoodhull gordonwoodhull deleted the bugfix/giscus-without-dark-mode-1.8 branch May 7, 2025 11:17
@posit-snyk-bot
Copy link
Copy Markdown
Collaborator

posit-snyk-bot commented May 7, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

giscus not working without dark mode

2 participants